Dev studio expands <throttle id="ip-throttling"/>

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Dev studio expands <throttle id="ip-throttling"/>

Lahiru Sandaruwan
Hi,

As per [1], when throttling mediator is used in out sequence, it should be one liner, such as <throttle id="ip-throttling">. But when we save that in Developer studio, it expands to following,

            <throttle id="ip-throttling">
                <onReject/>
                <onAccept/>
            </throttle>

Looks like a bug. Could we fix?


Thanks.
--
--

Lahiru Sandaruwan
Associate Technical Lead,
WSO2 Inc., http://wso2.com


_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: Dev studio expands <throttle id="ip-throttling"/>

Kevin Ratnasekera-2
Hi Lahiru,

As far as I can remember, you no longer need to have empty throttle mediator tag in OUT sequence, with same throttle id as in IN sequence. This empty throttle mediator tag served purpose of decrementing concurrency throttling counter ( number or parallel flows ) which was incremented IN sequence throttle mediator. However in order to support concurrency throttling for out only flows as well, we did some modifications as per [1] users no longer need to explicitly add to OUT sequence, those are now internally handled. Additionally throttle mediator will only engage on request message paths. Have you tried samples without throttle mediator in out sequence? I think it should work without a issue. Seems these samples need to be updated. [2]

[1] https://github.com/wso2/wso2-synapse/pull/26
[2] https://docs.wso2.com/display/ESB500/Throttle+Mediator

Regards
Kevin

On Fri, Dec 22, 2017 at 4:28 AM, Lahiru Sandaruwan <[hidden email]> wrote:
Hi,

As per [1], when throttling mediator is used in out sequence, it should be one liner, such as <throttle id="ip-throttling">. But when we save that in Developer studio, it expands to following,

            <throttle id="ip-throttling">
                <onReject/>
                <onAccept/>
            </throttle>

Looks like a bug. Could we fix?


Thanks.
--
--

Lahiru Sandaruwan
Associate Technical Lead,
WSO2 Inc., http://wso2.com

lean.enterprise.middleware

m: <a href="tel:(901)%20530-2379" value="+19015302379" target="_blank">+1 901 530 2379
e: [hidden email] b: https://medium.com/@lahirugmg



--
Kevin Ratnaskera
Software Engineer
WSO2 Inc. - http://wso2.com
lean . enterprise . middleware
Mobile - +94774696950

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: Dev studio expands <throttle id="ip-throttling"/>

Lahiru Sandaruwan
Hi Kevin,

Thanks for the response. [1] says below about 'Maximum Concurrent Accesses',

"When this parameter is used, the same Throttle mediator ID should be included in the response flow so that the completed responses are deducted from the available limit."

Do we need to update docs?


Thanks.



On Fri, Jan 5, 2018 at 6:54 AM, Kevin Ratnasekera <[hidden email]> wrote:
Hi Lahiru,

As far as I can remember, you no longer need to have empty throttle mediator tag in OUT sequence, with same throttle id as in IN sequence. This empty throttle mediator tag served purpose of decrementing concurrency throttling counter ( number or parallel flows ) which was incremented IN sequence throttle mediator. However in order to support concurrency throttling for out only flows as well, we did some modifications as per [1] users no longer need to explicitly add to OUT sequence, those are now internally handled. Additionally throttle mediator will only engage on request message paths. Have you tried samples without throttle mediator in out sequence? I think it should work without a issue. Seems these samples need to be updated. [2]

[1] https://github.com/wso2/wso2-synapse/pull/26
[2] https://docs.wso2.com/display/ESB500/Throttle+Mediator

Regards
Kevin

On Fri, Dec 22, 2017 at 4:28 AM, Lahiru Sandaruwan <[hidden email]> wrote:
Hi,

As per [1], when throttling mediator is used in out sequence, it should be one liner, such as <throttle id="ip-throttling">. But when we save that in Developer studio, it expands to following,

            <throttle id="ip-throttling">
                <onReject/>
                <onAccept/>
            </throttle>

Looks like a bug. Could we fix?


Thanks.
--
--

Lahiru Sandaruwan
Associate Technical Lead,
WSO2 Inc., http://wso2.com

lean.enterprise.middleware

m: <a href="tel:(901)%20530-2379" value="+19015302379" target="_blank">+1 901 530 2379
e: [hidden email] b: https://medium.com/@lahirugmg



--
Kevin Ratnaskera
Software Engineer
WSO2 Inc. - http://wso2.com
lean . enterprise . middleware
Mobile - <a href="tel:077%20469%206950" value="+94774696950" target="_blank">+94774696950

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev




--
--

Lahiru Sandaruwan
Associate Technical Lead,
WSO2 Inc., http://wso2.com

lean.enterprise.middleware

m: <a href="tel:+1%20901-530-2379" value="+19015302379" target="_blank">+1 901 530 2379
e: [hidden email] b: https://medium.com/@lahirugmg

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: Dev studio expands <throttle id="ip-throttling"/>

Kevin Ratnasekera-2
Hi Lahiru,

Yes, the statement you pointed out is no longer a valid statement. We need to correct the documentation. [1]  Thanks for pointing out.

[1] https://github.com/wso2/wso2-synapse/pull/265

Regards
Kevin

On Thu, Jan 11, 2018 at 10:03 PM, Lahiru Sandaruwan <[hidden email]> wrote:
Hi Kevin,

Thanks for the response. [1] says below about 'Maximum Concurrent Accesses',

"When this parameter is used, the same Throttle mediator ID should be included in the response flow so that the completed responses are deducted from the available limit."

Do we need to update docs?


Thanks.



On Fri, Jan 5, 2018 at 6:54 AM, Kevin Ratnasekera <[hidden email]> wrote:
Hi Lahiru,

As far as I can remember, you no longer need to have empty throttle mediator tag in OUT sequence, with same throttle id as in IN sequence. This empty throttle mediator tag served purpose of decrementing concurrency throttling counter ( number or parallel flows ) which was incremented IN sequence throttle mediator. However in order to support concurrency throttling for out only flows as well, we did some modifications as per [1] users no longer need to explicitly add to OUT sequence, those are now internally handled. Additionally throttle mediator will only engage on request message paths. Have you tried samples without throttle mediator in out sequence? I think it should work without a issue. Seems these samples need to be updated. [2]

[1] https://github.com/wso2/wso2-synapse/pull/26
[2] https://docs.wso2.com/display/ESB500/Throttle+Mediator

Regards
Kevin

On Fri, Dec 22, 2017 at 4:28 AM, Lahiru Sandaruwan <[hidden email]> wrote:
Hi,

As per [1], when throttling mediator is used in out sequence, it should be one liner, such as <throttle id="ip-throttling">. But when we save that in Developer studio, it expands to following,

            <throttle id="ip-throttling">
                <onReject/>
                <onAccept/>
            </throttle>

Looks like a bug. Could we fix?


Thanks.
--
--

Lahiru Sandaruwan
Associate Technical Lead,
WSO2 Inc., http://wso2.com

lean.enterprise.middleware

m: <a href="tel:(901)%20530-2379" value="+19015302379" target="_blank">+1 901 530 2379
e: [hidden email] b: https://medium.com/@lahirugmg



--
Kevin Ratnaskera
Software Engineer
WSO2 Inc. - http://wso2.com
lean . enterprise . middleware
Mobile - <a href="tel:077%20469%206950" value="+94774696950" target="_blank">+94774696950

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev




--
--

Lahiru Sandaruwan
Associate Technical Lead,
WSO2 Inc., http://wso2.com

lean.enterprise.middleware

m: <a href="tel:+1%20901-530-2379" value="+19015302379" target="_blank">+1 901 530 2379
e: [hidden email] b: https://medium.com/@lahirugmg



--
Kevin Ratnaskera
Software Engineer
WSO2 Inc. - http://wso2.com
lean . enterprise . middleware
Mobile - +94774696950

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: Dev studio expands <throttle id="ip-throttling"/>

Kevin Ratnasekera-2
Seems I missed the correct PR. [1]

[1] https://github.com/wso2/wso2-synapse/pull/265

Regards
Kevin

On Fri, Jan 12, 2018 at 12:03 PM, Kevin Ratnasekera <[hidden email]> wrote:
Hi Lahiru,

Yes, the statement you pointed out is no longer a valid statement. We need to correct the documentation. [1]  Thanks for pointing out.

[1] https://github.com/wso2/wso2-synapse/pull/265

Regards
Kevin

On Thu, Jan 11, 2018 at 10:03 PM, Lahiru Sandaruwan <[hidden email]> wrote:
Hi Kevin,

Thanks for the response. [1] says below about 'Maximum Concurrent Accesses',

"When this parameter is used, the same Throttle mediator ID should be included in the response flow so that the completed responses are deducted from the available limit."

Do we need to update docs?


Thanks.



On Fri, Jan 5, 2018 at 6:54 AM, Kevin Ratnasekera <[hidden email]> wrote:
Hi Lahiru,

As far as I can remember, you no longer need to have empty throttle mediator tag in OUT sequence, with same throttle id as in IN sequence. This empty throttle mediator tag served purpose of decrementing concurrency throttling counter ( number or parallel flows ) which was incremented IN sequence throttle mediator. However in order to support concurrency throttling for out only flows as well, we did some modifications as per [1] users no longer need to explicitly add to OUT sequence, those are now internally handled. Additionally throttle mediator will only engage on request message paths. Have you tried samples without throttle mediator in out sequence? I think it should work without a issue. Seems these samples need to be updated. [2]

[1] https://github.com/wso2/wso2-synapse/pull/26
[2] https://docs.wso2.com/display/ESB500/Throttle+Mediator

Regards
Kevin

On Fri, Dec 22, 2017 at 4:28 AM, Lahiru Sandaruwan <[hidden email]> wrote:
Hi,

As per [1], when throttling mediator is used in out sequence, it should be one liner, such as <throttle id="ip-throttling">. But when we save that in Developer studio, it expands to following,

            <throttle id="ip-throttling">
                <onReject/>
                <onAccept/>
            </throttle>

Looks like a bug. Could we fix?


Thanks.
--
--

Lahiru Sandaruwan
Associate Technical Lead,
WSO2 Inc., http://wso2.com

lean.enterprise.middleware

m: <a href="tel:(901)%20530-2379" value="+19015302379" target="_blank">+1 901 530 2379
e: [hidden email] b: https://medium.com/@lahirugmg



--
Kevin Ratnaskera
Software Engineer
WSO2 Inc. - http://wso2.com
lean . enterprise . middleware
Mobile - <a href="tel:077%20469%206950" value="+94774696950" target="_blank">+94774696950

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev




--
--

Lahiru Sandaruwan
Associate Technical Lead,
WSO2 Inc., http://wso2.com

lean.enterprise.middleware

m: <a href="tel:+1%20901-530-2379" value="+19015302379" target="_blank">+1 901 530 2379
e: [hidden email] b: https://medium.com/@lahirugmg



--
Kevin Ratnaskera
Software Engineer
WSO2 Inc. - http://wso2.com
lean . enterprise . middleware
Mobile - <a href="tel:+94%2077%20469%206950" value="+94774696950" target="_blank">+94774696950



--
Kevin Ratnaskera
Software Engineer
WSO2 Inc. - http://wso2.com
lean . enterprise . middleware
Mobile - +94774696950

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev