HTTP Verb PATCH support for MSF4J

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

HTTP Verb PATCH support for MSF4J

Gayan Gunawardana
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Afkham Azeez-2
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: +94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Afkham Azeez-2
Someone suggested on SO to use the PATCH annotation from io.swagger.jaxrs

That may be a good alternative since we already support Swagger.

On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[hidden email]> wrote:
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: +94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Gayan Gunawardana


On Sun, Feb 26, 2017 at 11:48 PM, Afkham Azeez <[hidden email]> wrote:
Someone suggested on SO to use the PATCH annotation from io.swagger.jaxrs

That may be a good alternative since we already support Swagger.
Thanks for the alternative so we can go with io.swagger.jaxrs.PATCH.

On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[hidden email]> wrote:
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Thusitha Thilina Dayaratne
Hi Azeez,

Since we restructured swagger support as a separate dependency, if we use swagger PATCH annotation then we have to bring swagger dependency again to the core. That will increase the minimum jar size. Therefore IMHO it would be better if we implement the PATCH annotation without depending on Swagger.
WDYT?

Thanks
Thusitha

On Mon, Feb 27, 2017 at 12:00 AM, Gayan Gunawardana <[hidden email]> wrote:


On Sun, Feb 26, 2017 at 11:48 PM, Afkham Azeez <[hidden email]> wrote:
Someone suggested on SO to use the PATCH annotation from io.swagger.jaxrs

That may be a good alternative since we already support Swagger.
Thanks for the alternative so we can go with io.swagger.jaxrs.PATCH.

On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[hidden email]> wrote:
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809



_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Afkham Azeez-2


On Mon, Feb 27, 2017 at 6:21 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Hi Azeez,

Since we restructured swagger support as a separate dependency, if we use swagger PATCH annotation then we have to bring swagger dependency again to the core. That will increase the minimum jar size. Therefore IMHO it would be better if we implement the PATCH annotation without depending on Swagger.
WDYT?

Yeah since it is a simple annotation we may add that to the msf4j core itself. 

Thanks
Thusitha

On Mon, Feb 27, 2017 at 12:00 AM, Gayan Gunawardana <[hidden email]> wrote:


On Sun, Feb 26, 2017 at 11:48 PM, Afkham Azeez <[hidden email]> wrote:
Someone suggested on SO to use the PATCH annotation from io.swagger.jaxrs

That may be a good alternative since we already support Swagger.
Thanks for the alternative so we can go with io.swagger.jaxrs.PATCH.

On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[hidden email]> wrote:
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  <a href="tel:071%20275%206809" value="+94712756809" target="_blank">+94712756809





--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: +94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Thusitha Thilina Dayaratne
Created issue[1] to track this.


Thanks
Thusitha

On Mon, Feb 27, 2017 at 8:41 AM, Afkham Azeez <[hidden email]> wrote:


On Mon, Feb 27, 2017 at 6:21 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Hi Azeez,

Since we restructured swagger support as a separate dependency, if we use swagger PATCH annotation then we have to bring swagger dependency again to the core. That will increase the minimum jar size. Therefore IMHO it would be better if we implement the PATCH annotation without depending on Swagger.
WDYT?

Yeah since it is a simple annotation we may add that to the msf4j core itself. 

Thanks
Thusitha

On Mon, Feb 27, 2017 at 12:00 AM, Gayan Gunawardana <[hidden email]> wrote:


On Sun, Feb 26, 2017 at 11:48 PM, Afkham Azeez <[hidden email]> wrote:
Someone suggested on SO to use the PATCH annotation from io.swagger.jaxrs

That may be a good alternative since we already support Swagger.
Thanks for the alternative so we can go with io.swagger.jaxrs.PATCH.

On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[hidden email]> wrote:
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  <a href="tel:071%20275%206809" value="+94712756809" target="_blank">+94712756809





--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809



_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Malintha Amarasinghe
Hi all,

Just wanted to check whether we were able to implement this? Looking at the code I guess we do not support PATCH in msf4j yet [1]. We have some requirements to implement partial update operations in SCIM2 API via msf4j: Eg: Adding a user to an existing group without updating the whole group at once [2]


Thanks!
Malintha


On Mon, Feb 27, 2017 at 9:01 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Created issue[1] to track this.


Thanks
Thusitha

On Mon, Feb 27, 2017 at 8:41 AM, Afkham Azeez <[hidden email]> wrote:


On Mon, Feb 27, 2017 at 6:21 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Hi Azeez,

Since we restructured swagger support as a separate dependency, if we use swagger PATCH annotation then we have to bring swagger dependency again to the core. That will increase the minimum jar size. Therefore IMHO it would be better if we implement the PATCH annotation without depending on Swagger.
WDYT?

Yeah since it is a simple annotation we may add that to the msf4j core itself. 

Thanks
Thusitha

On Mon, Feb 27, 2017 at 12:00 AM, Gayan Gunawardana <[hidden email]> wrote:


On Sun, Feb 26, 2017 at 11:48 PM, Afkham Azeez <[hidden email]> wrote:
Someone suggested on SO to use the PATCH annotation from io.swagger.jaxrs

That may be a good alternative since we already support Swagger.
Thanks for the alternative so we can go with io.swagger.jaxrs.PATCH.

On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[hidden email]> wrote:
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  <a href="tel:071%20275%206809" value="+94712756809" target="_blank">+94712756809





--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809



_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev




--
Malintha Amarasinghe
WSO2, Inc. - lean | enterprise | middleware

Mobile : +94 712383306

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Thusitha Thilina Dayaratne-2
Hi Malintha,

AFAIK this was not implemented.
It seems like there is an open PR relate to this. IMHO that can be merged to get the PATCH support if the PR looks good.


On Wed, Aug 8, 2018 at 3:29 AM Malintha Amarasinghe <[hidden email]> wrote:
Hi all,

Just wanted to check whether we were able to implement this? Looking at the code I guess we do not support PATCH in msf4j yet [1]. We have some requirements to implement partial update operations in SCIM2 API via msf4j: Eg: Adding a user to an existing group without updating the whole group at once [2]


Thanks!
Malintha


On Mon, Feb 27, 2017 at 9:01 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Created issue[1] to track this.


Thanks
Thusitha

On Mon, Feb 27, 2017 at 8:41 AM, Afkham Azeez <[hidden email]> wrote:


On Mon, Feb 27, 2017 at 6:21 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Hi Azeez,

Since we restructured swagger support as a separate dependency, if we use swagger PATCH annotation then we have to bring swagger dependency again to the core. That will increase the minimum jar size. Therefore IMHO it would be better if we implement the PATCH annotation without depending on Swagger.
WDYT?

Yeah since it is a simple annotation we may add that to the msf4j core itself. 

Thanks
Thusitha

On Mon, Feb 27, 2017 at 12:00 AM, Gayan Gunawardana <[hidden email]> wrote:


On Sun, Feb 26, 2017 at 11:48 PM, Afkham Azeez <[hidden email]> wrote:
Someone suggested on SO to use the PATCH annotation from io.swagger.jaxrs

That may be a good alternative since we already support Swagger.
Thanks for the alternative so we can go with io.swagger.jaxrs.PATCH.

On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[hidden email]> wrote:
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  <a href="tel:071%20275%206809" value="+94712756809" target="_blank">+94712756809





--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809



_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev




--
Malintha Amarasinghe
WSO2, Inc. - lean | enterprise | middleware

Mobile : +94 712383306
_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev


--
Thusitha Thilina Dayaratne
PhD Student - Cybersecurity Lab
Monash University


_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Afkham Azeez-2
Malintha can you please look into that PR?

On Wed, Aug 22, 2018, 6:34 AM Thusitha Thilina Dayaratne <[hidden email]> wrote:
Hi Malintha,

AFAIK this was not implemented.
It seems like there is an open PR relate to this. IMHO that can be merged to get the PATCH support if the PR looks good.


On Wed, Aug 8, 2018 at 3:29 AM Malintha Amarasinghe <[hidden email]> wrote:
Hi all,

Just wanted to check whether we were able to implement this? Looking at the code I guess we do not support PATCH in msf4j yet [1]. We have some requirements to implement partial update operations in SCIM2 API via msf4j: Eg: Adding a user to an existing group without updating the whole group at once [2]


Thanks!
Malintha


On Mon, Feb 27, 2017 at 9:01 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Created issue[1] to track this.


Thanks
Thusitha

On Mon, Feb 27, 2017 at 8:41 AM, Afkham Azeez <[hidden email]> wrote:


On Mon, Feb 27, 2017 at 6:21 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Hi Azeez,

Since we restructured swagger support as a separate dependency, if we use swagger PATCH annotation then we have to bring swagger dependency again to the core. That will increase the minimum jar size. Therefore IMHO it would be better if we implement the PATCH annotation without depending on Swagger.
WDYT?

Yeah since it is a simple annotation we may add that to the msf4j core itself. 

Thanks
Thusitha

On Mon, Feb 27, 2017 at 12:00 AM, Gayan Gunawardana <[hidden email]> wrote:


On Sun, Feb 26, 2017 at 11:48 PM, Afkham Azeez <[hidden email]> wrote:
Someone suggested on SO to use the PATCH annotation from io.swagger.jaxrs

That may be a good alternative since we already support Swagger.
Thanks for the alternative so we can go with io.swagger.jaxrs.PATCH.

On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[hidden email]> wrote:
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:077%20332%200919" value="+94773320919" target="_blank" rel="noreferrer">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank" rel="noreferrer">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  <a href="tel:071%20275%206809" value="+94712756809" target="_blank" rel="noreferrer">+94712756809





--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" target="_blank" rel="noreferrer">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809



_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev




--
Malintha Amarasinghe
WSO2, Inc. - lean | enterprise | middleware

Mobile : +94 712383306
_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev


--
Thusitha Thilina Dayaratne
PhD Student - Cybersecurity Lab
Monash University

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev
Reply | Threaded
Open this post in threaded view
|

Re: HTTP Verb PATCH support for MSF4J

Malintha Amarasinghe
Hi Thusitha, 

Thank you very much for the info.

Hi Azeez,

I am afraid I can check this ATM as I am tied with support work. I will check with someone with the team and ask to verify this.

Thanks!

On Wed, Aug 22, 2018 at 8:16 AM, Afkham Azeez <[hidden email]> wrote:
Malintha can you please look into that PR?

On Wed, Aug 22, 2018, 6:34 AM Thusitha Thilina Dayaratne <[hidden email]> wrote:
Hi Malintha,

AFAIK this was not implemented.
It seems like there is an open PR relate to this. IMHO that can be merged to get the PATCH support if the PR looks good.


On Wed, Aug 8, 2018 at 3:29 AM Malintha Amarasinghe <[hidden email]> wrote:
Hi all,

Just wanted to check whether we were able to implement this? Looking at the code I guess we do not support PATCH in msf4j yet [1]. We have some requirements to implement partial update operations in SCIM2 API via msf4j: Eg: Adding a user to an existing group without updating the whole group at once [2]


Thanks!
Malintha


On Mon, Feb 27, 2017 at 9:01 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Created issue[1] to track this.


Thanks
Thusitha

On Mon, Feb 27, 2017 at 8:41 AM, Afkham Azeez <[hidden email]> wrote:


On Mon, Feb 27, 2017 at 6:21 AM, Thusitha Thilina Dayaratne <[hidden email]> wrote:
Hi Azeez,

Since we restructured swagger support as a separate dependency, if we use swagger PATCH annotation then we have to bring swagger dependency again to the core. That will increase the minimum jar size. Therefore IMHO it would be better if we implement the PATCH annotation without depending on Swagger.
WDYT?

Yeah since it is a simple annotation we may add that to the msf4j core itself. 

Thanks
Thusitha

On Mon, Feb 27, 2017 at 12:00 AM, Gayan Gunawardana <[hidden email]> wrote:


On Sun, Feb 26, 2017 at 11:48 PM, Afkham Azeez <[hidden email]> wrote:
Someone suggested on SO to use the PATCH annotation from io.swagger.jaxrs

That may be a good alternative since we already support Swagger.
Thanks for the alternative so we can go with io.swagger.jaxrs.PATCH.

On Sun, Feb 26, 2017 at 11:46 PM, Afkham Azeez <[hidden email]> wrote:
We can add that annotation to MSF4J itself.

On Sun, Feb 26, 2017 at 11:28 PM, Gayan Gunawardana <[hidden email]> wrote:
Hi All,

Since javax.ws.rs does not provide http verb PATCH we have to have custom Patch annotation as below.
@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@HttpMethod("PATCH")
public @interface PATCH {
}
Is it ok to have this annotation in component level or is there any common place we can put this annotation ?

Alternatively we can use "X-HTTP-Method-Override" header too.

WDYT ?

Thanks,
Gayan
-- 
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:077%20332%200919" value="+94773320919" rel="noreferrer" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" rel="noreferrer" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Gayan Gunawardana
Software Engineer; WSO2 Inc.; http://wso2.com/



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  <a href="tel:071%20275%206809" value="+94712756809" rel="noreferrer" target="_blank">+94712756809





--
Afkham Azeez
Senior Director, Platform ArchitectureWSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/

email:
[hidden email] cell: <a href="tel:+94%2077%20332%200919" value="+94773320919" rel="noreferrer" target="_blank">+94 77 3320919
blog:
http://blog.afkham.org
twitter:
http://twitter.com/afkham_azeez
linked-in:
http://lk.linkedin.com/in/afkhamazeez

Lean . Enterprise . Middleware



--
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809



_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev




--
Malintha Amarasinghe
WSO2, Inc. - lean | enterprise | middleware

Mobile : +94 712383306
_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev


--
Thusitha Thilina Dayaratne
PhD Student - Cybersecurity Lab
Monash University

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev



--
Malintha Amarasinghe
WSO2, Inc. - lean | enterprise | middleware

Mobile : +94 712383306

_______________________________________________
Dev mailing list
[hidden email]
http://wso2.org/cgi-bin/mailman/listinfo/dev